[waiting for typed_ast changes] Implement PEP 526 in typed_ast #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Sep 14, 2016
| @@ -89,7 +89,7 @@ class Delete(stmt): | |||
| class Assign(stmt): | |||
| targets = ... # type: typing.List[expr] | |||
| value = ... # type: expr | |||
| type_comment = ... # type: Optional[str] | |||
| type_comment = ... # type: Union[AST, Optional[str]] | |||
There was a problem hiding this comment.
Would it be safe to merge this even if typed_ast isn't merged yet?
There was a problem hiding this comment.
@gvanrossum It's OK without typed_ast, but mypy will complain about its own code
mypy/fastparse.py:411: error: Argument 1 to "parse_type_comment" has incompatible type
"Union[AST, str]"; expected "str"
So that this PR should go together with the one at mypy. The PR to mypy is made in such a way that it will continue to work with old typed_ast.
gvanrossum
approved these changes
Sep 14, 2016
gvanrossum
changed the title
ddfisher
reviewed
Sep 27, 2016
| @@ -1,2 +1,4 @@ | |||
| # This module is a fork of the CPython 2.7 and 3.5 ast modules with PEP 484 support. | |||
| # See: https://github.com/dropbox/typed_ast | |||
|
|
|||
| __version__ = ... # type: str | |||
There was a problem hiding this comment.
This is now no longer part of typed_ast.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.