improve typing in inspect #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Sep 10, 2021
stdlib/inspect.pyi
Outdated
| def __init__( | ||
| self, parameters: Sequence[Parameter] | None = ..., *, return_annotation: Any = ..., __validate_parameters__: bool = ... | ||
| ) -> None: ... | ||
| empty: ClassVar[Type[_empty]] |
There was a problem hiding this comment.
Did you try just writing empty = _empty?
There was a problem hiding this comment.
yeah, I did and Python 3.10 complains
inspect.Signature.empty variable differs from runtime type Literal[<class 'inspect._empty'>]and 3.8 and 3.9
inspect.Signature.empty variable differs from runtime type builtins.typeThere was a problem hiding this comment.
I assume stubtest complains, but the other tests run? In that case, I'd suggest to just silence the stubtest warnings. But maybe @hauntsaninja has a different opinion?
There was a problem hiding this comment.
Seems like it should be fine? Not sure what type checkers think of type aliases within class scope, possible something like that is what's throwing stubtest off
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx.git)
+ sphinx/util/inspect.py:670: error: unused "type: ignore" comment
+ sphinx/util/inspect.py: note: In function "signature_from_ast":
+ sphinx/util/inspect.py:802:27: error: Incompatible types in assignment (expression has type "DefaultValue", variable has type "_empty")
+ sphinx/util/inspect.py:812:23: error: Incompatible types in assignment (expression has type "DefaultValue", variable has type "_empty")
|
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I implemented the private marker
_emptyand_voidcorrectly 😄