Add stub file for xml/dom/xmlbuilder.py

[AlexWaygood]

I made a stab at adding stubs for xml/dom/xmlbuilder.py (cpython source code here). A little tricky, since documentation is rather thin on the ground, but perhaps an improvement on what's there at the moment?

[AlexWaygood]

The errors in the failing tests are:

• "error: xml.dom.xmlbuilder.ExpatBuilder is not present at runtime"
• "error: xml.dom.xmlbuilder.ExpatBuilderNS is not present at runtime"

Have I done something wrong there? The CONTRIBUTING.md file said: "Imports in stubs are considered private (not part of the exported API)."

Also, I included several methods that always raised errors, annotating them as returning NoReturn -- is that preferred, or should I have left them out?

[Akuli]

The CI failure looks like a bug to me. It is most likely a bug in mypy, as stubtest uses mypy internally. It might be python/mypy#10661

[hauntsaninja]

Okay, confirmed mypy bug. Here's the fix: python/mypy#11411

For now, I recommend adding it to stubtest's allowlist here: https://github.com/python/typeshed/blob/master/tests/stubtest_allowlists/py3_common.txt

If you then also want to run isort against this PR, CI will be green

[AlexWaygood]

Okay, confirmed mypy bug. Here's the fix: python/mypy#11411

For now, I recommend adding it to stubtest's allowlist here: https://github.com/python/typeshed/blob/master/tests/stubtest_allowlists/py3_common.txt

If you then also want to run isort against this PR, CI will be green

🥳 CI is now green -- thanks!

[Akuli]

It seems that everyone somehow forgot about this :)

[AlexWaygood]

It seems that everyone somehow forgot about this :)

The PR rises from the dead!

[Akuli]

You need to merge the latest master into the branch of this PR.

[AlexWaygood]

You need to merge the latest master into the branch of this PR.

Oh, I think I understand how this happened. If it isn't the consequences of my own actions.

[Akuli]

This PR conflicted with #6379, which is not surprising because #6379 changed many lines.

[Akuli]

Much better than what was there before.

[AlexWaygood]

Much better than what was there before.

Thank you for the patient reviews :)

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[AlexWaygood]

🙌🙌