Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Literal and __all__ in binhex #6845

Merged
merged 3 commits into from
Jan 9, 2022
Merged

Use Literal and __all__ in binhex #6845

merged 3 commits into from
Jan 9, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 6, 2022

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

sobolevn commented Jan 6, 2022 

 Stub: at line 10
Literal[b'\\x90']
Runtime:
b'\x90'

@hauntsaninja is it valid? Or is it a bug?

@hauntsaninja
Copy link
Collaborator

Seems like a bug

This was referenced Jan 7, 2022
Merged
Closed
@sobolevn
Copy link
Member Author

sobolevn commented Jan 7, 2022

@hauntsaninja should this be closed? I guess it can wait for 0.931 release

@JelleZijlstra JelleZijlstra reopened this Jan 7, 2022
@github-actions

This comment has been minimized.

Sign in to view
@sobolevn
Copy link
Member Author

sobolevn commented Jan 9, 2022

Rebased, now Literal[bytes] should work!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

sobolevn commented Jan 9, 2022

Awesome!

@srittau srittau merged commit bb6a6e3 into python:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @hauntsaninja @srittau @JelleZijlstra