Further improve mypy_test.py
#7484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/mypy_test.py
Outdated
| if not is_supported(distribution, major): | ||
| distribution_path = Path("stubs", distribution) | ||
|
|
||
| if not is_probably_stubs_folder(distribution_path): |
There was a problem hiding this comment.
How will we catch it if somebody forgets to put a METADATA.toml in a new stubs folder?
There was a problem hiding this comment.
Any better after 83b05f3?
JelleZijlstra
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stubsdirectory. (I had a few.mypy_cachefolders and extra codemodding scripts in various places, which meant that the test was crashing. Thedist_path / "METADATA.toml"call in theis_supportedfunction was evaluating to a nonexistent filepath.)