Daniel sandbox #62
Open
Daniel sandbox #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Oct 24, 2020
lira/parsers/rst.py
Outdated
| def is_importable(value): | ||
| module_name, class_name = value.rsplit(".",1) | ||
| MyClass = getattr(importlib.import_module(module_name), class_name, ValueError) | ||
| if MyClass is ValueError: |
There was a problem hiding this comment.
We need to check for validator_class is not None and isinstance(validator_class, Validator)
lira/parsers/rst.py
Outdated
| return value | ||
| def is_importable(value): | ||
| module_name, class_name = value.rsplit(".",1) | ||
| MyClass = getattr(importlib.import_module(module_name), class_name, ValueError) |
There was a problem hiding this comment.
We need to try...except in case there is an import error.
Co-authored-by: Santos Gallegos <[email protected]>
|
You can take some inspiration from Lines 72 to 77 in df8ee50 |
stsewd
reviewed
Oct 29, 2020
lira/parsers/rst.py
Outdated
Comment on lines
32
to
33
| MyClass = getattr(importlib.import_module(module_name), class_name, None) | ||
| instance = MyClass() |
There was a problem hiding this comment.
We don't need to create an instance (I think), we just need to check if the class is a subclass of lira.validators.Validator
stsewd
reviewed
Oct 31, 2020
| MyClass = getattr(importlib.import_module(module_name), class_name, None) | ||
| if MyClass is None or not issubclass(MyClass, Validator): | ||
| raise ValueError | ||
| else: |
stsewd
reviewed
Oct 31, 2020
lira/parsers/rst.py
Outdated
| def is_importable(value): | ||
| module_name, class_name = value.rsplit(".", 1) | ||
| try: | ||
| MyClass = getattr(importlib.import_module(module_name), class_name, None) |
There was a problem hiding this comment.
We should name this TargetClass or something like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#TODO: check if value can be imported.