Set SanitizedResponse content to bytes instead of string

The `content` property of a `Response` object is expected to always be bytes (the `text` property should be a string). This change fixes an issue where consumers of the library that were returned a `SanitizedResponse` object could fail because they expected the `content` attribute of it to be bytes instead of a string. Signed-off-by: Carey Metcalfe <[email protected]>
pythongssapi · Feb 16, 2024 · f978789 · f978789
1 parent 84e052b
commit f978789
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/requests_gssapi/gssapi_.py b/requests_gssapi/gssapi_.py
@@ -54,7 +54,7 @@ def __init__(self, response):
         self.connection = response.connection
         self._content_consumed = True
 
-        self._content = ""
+        self._content = b""
         self.cookies = cookiejar_from_dict({})
         self.headers = CaseInsensitiveDict()
         self.headers['content-length'] = '0'

diff --git a/test_requests_gssapi.py b/test_requests_gssapi.py
@@ -164,7 +164,7 @@ def test_authenticate_user(self):
             response.headers = {'www-authenticate': b64_negotiate_token}
             response.status_code = 401
             response.connection = connection
-            response._content = ""
+            response._content = b""
             response.raw = raw
             auth = requests_gssapi.HTTPKerberosAuth()
             r = auth.authenticate_user(response)
@@ -201,7 +201,7 @@ def test_handle_401(self):
             response.headers = {'www-authenticate': b64_negotiate_token}
             response.status_code = 401
             response.connection = connection
-            response._content = ""
+            response._content = b""
             response.raw = raw
             auth = requests_gssapi.HTTPKerberosAuth()
             r = auth.handle_401(response)
@@ -375,7 +375,8 @@ def test_handle_response_500_mutual_auth_required_failure(self):
             self.assertEqual(r.url, response_500.url)
             self.assertEqual(r.reason, response_500.reason)
             self.assertEqual(r.connection, response_500.connection)
-            self.assertEqual(r.content, '')
+            self.assertEqual(r.content, b"")
+            self.assertEqual(r.text, "")
             self.assertNotEqual(r.cookies, response_500.cookies)
 
             self.assertFalse(fail_resp.called)
@@ -436,7 +437,7 @@ def test_handle_response_401(self):
             response.headers = {'www-authenticate': b64_negotiate_token}
             response.status_code = 401
             response.connection = connection
-            response._content = ""
+            response._content = b""
             response.raw = raw
 
             auth = requests_gssapi.HTTPKerberosAuth()
@@ -482,7 +483,7 @@ def connection_send(self, *args, **kwargs):
             response.headers = {'www-authenticate': b64_negotiate_token}
             response.status_code = 401
             response.connection = connection
-            response._content = ""
+            response._content = b""
             response.raw = raw
 
             auth = requests_gssapi.HTTPKerberosAuth()
@@ -534,7 +535,7 @@ def test_delegation(self):
             response.headers = {'www-authenticate': b64_negotiate_token}
             response.status_code = 401
             response.connection = connection
-            response._content = ""
+            response._content = b""
             response.raw = raw
             auth = requests_gssapi.HTTPKerberosAuth(service="HTTP",
                                                     delegate=True)