Don't add the host to the target name if it wasn't given originally #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. This is a bit scope creep, but I wonder if we ought to have some docs for how to use a context on multiple hosts, or maybe a test. Unfortunately I didn't have this use case in mind when porting, so Let me know if you'd prefer me to make those changes. |
|
It's half designed already multiple hosts, so I would say it's probably best to support it completely. Feel free to make the changes when you have time, I'm definitely not an expert on that part. |
Previously, the Name was stored the first time the request header was generated. This locked the user into using only a single host, defeating the purpose of storing the contexts on a hostname basis. Fix this by not storing the Name object. [[email protected]: commit message, updated docstr for target_name] Merges: pythongssapi#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the target_name is updated to include the host the first time a request header is generated if the target_name is a string without an '@'. This locks the user into using only a single host, defeating the purpose of storing the contexts on a hostname basis.
I've updated the code to not update the target_name inplace and instead just use it to create the security context.