Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-based line cache, to prevent reentrancy deadlocks and GIL deadlocks #375

Merged
merged 4 commits into from
May 19, 2022

Conversation

itamarst
Copy link
Collaborator

@itamarst itamarst commented May 19, 2022

Fixes #374

Fixes #365

Fixes #349

@github-actions
Copy link

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..363bd66 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"3771157 (188.06264867688517%)",-]{+"4618223 (207.76862740247913%)",+}
    "D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3899983 (1375.5755650987921%)",+}
    "DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2115233 (3570.382766484553%)",+}
    "DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2941619 (2054.3953014025365%)",+}
    "Dr": [-"231060633 (375.8621692938787%)",-]{+"210677265 (355.6507087895063%)",+}
    "Dw": [-"88001037 (338.04076205255154%)",-]{+"80162151 (323.7473311743151%)",+}
    "I1mr": [-"3555117 (1291.257363437142%)",-]{+"4041633 (1441.7278057007031%)",+}
    "ILmr": [-"14685 (224.7663551401869%)",-]{+"17451 (248.78506266518886%)",+}
    "Ir": [-"872039764 (403.39198904097907%)",-]{+"803053325 (382.5143059807906%)",+}
    "Overall": [-"1332452656 (406.55387644593173%)"-]{+"1296361187 (402.356517228167%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..83c2fc4 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"1866984 (413.64545831772375%)",-]{+"1849477 (408.53619068591144%)",+}
    "D1mw": [-"393456 (455.7661355950594%)",-]{+"394382 (456.6840615362353%)",+}
    "DLmr": [-"59324 (493.26483261518064%)",-]{+"58250 (482.4939260621183%)",+}
    "DLmw": [-"77459 (220.9427598913281%)",-]{+"79268 (224.02678683189384%)",+}
    "Dr": [-"77161209 (571.2328286082947%)",-]{+"62386109 (493.57095591976406%)",+}
    "Dw": [-"30820902 (440.2169730406361%)",-]{+"24739340 (388.7112073351875%)",+}
    "I1mr": [-"1638950 (586.5692113122628%)",-]{+"1656992 (587.6718779431154%)",+}
    "ILmr": [-"7958 (171.83607149304927%)",-]{+"8622 (177.1888988361683%)",+}
    "Ir": [-"254542209 (491.30873094686683%)",-]{+"213002961 (435.82583217115035%)",+}
    "Overall": [-"382464110 (492.83707107089475%)"-]{+"320116014 (437.8345689041823%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..e53a461 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"4542966 (144.07376585255872%)",-]{+"7479225 (188.37476152293527%)",+}
    "D1mw": [-"1628141 (267.75567903740483%)",-]{+"1263903 (193.73388361718932%)",+}
    "DLmr": [-"32802 (331.7507418397626%)",-]{+"31481 (320.5323992994746%)",+}
    "DLmw": [-"65725 (241.46577701248387%)",-]{+"66930 (244.357691312225%)",+}
    "Dr": [-"367659717 (157.6310977517437%)",-]{+"301901315 (147.4932340959896%)",+}
    "Dw": [-"143586175 (159.9837295595579%)",-]{+"123175831 (151.8621060932252%)",+}
    "I1mr": [-"8784651 (214.74165578852526%)",-]{+"7492371 (199.7358170031563%)",+}
    "ILmr": [-"7924 (170.99086185271457%)",-]{+"8532 (175.8265197298258%)",+}
    "Ir": [-"1160233461 (157.01681262908485%)",-]{+"1027975816 (150.63624123693924%)",+}
    "Overall": [-"1734495915 (158.00764418609307%)"-]{+"1521203248 (151.1371984887234%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..1157043 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2022.3.1.dev28+g61cc97d.d20220519+}

@itamarst itamarst merged commit f014839 into master May 19, 2022
@itamarst itamarst deleted the 374-rust-line-cache branch May 19, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of Python linecache with Rust line cache SIGUSR2 causes Fil to exit Hangs on Apple Silicon
1 participant