-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LayoutType -> Layout #1035
Open
jainapurva
wants to merge
4
commits into
gh/jainapurva/2/base
Choose a base branch
from
gh/jainapurva/2/head
base: gh/jainapurva/2/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+348
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1035
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit a7dead4 with merge base 92dd5f5 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 1b04687268c47d790ccac99f5b36fecb24fa5947 Pull Request resolved: #1035
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 8, 2024
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: c11b4b6d1ec8ceb66ea7a3e8e5494874d7ddefaf Pull Request resolved: #1035
jerryzh168
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, thanks!
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 56976fdbd4fccd00ded4059bea282cc8812f2d4b Pull Request resolved: #1035
jainapurva
added a commit
that referenced
this pull request
Oct 8, 2024
ghstack-source-id: 2fbd5ea6c74418f75fb2856365cb2f0b94486104 Pull Request resolved: #1035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):