Update README.md #140
Merged
Update README.md #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to include 1. the interoperability details 2. our goals 3. some general cleanup
facebook-github-bot
added
the
CLA Signed
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
README.md
Outdated
| @@ -1,20 +1,30 @@ | |||
| # torchao: PyTorch Architecture Optimization | |||
There was a problem hiding this comment.
first question i always get is what does ao mean so let's answer that somewheere in the first 3 lines
There was a problem hiding this comment.
I think this got deleted by mistake, I'll add it back
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
README.md
Outdated
| ## Key Features | ||
| * Native PyTorch techniques, composable with torch.compile | ||
| * APIs tested on following hardware - A100, T4(colab) | ||
| * Supports the following eager quantization techniques. |
There was a problem hiding this comment.
so which techniques are compile specific and which are eager? If it's the same set then we can set say something like kernels that work with both eager and compile such as: int8 etc..
There was a problem hiding this comment.
I think they all work with both. @HDCharles or @jerryzh168 can you confirm?
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
reviewed
Apr 16, 2024
msaroufim
approved these changes
Apr 16, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Update README.md Update to include 1. the interoperability details 2. our goals 3. some general cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to include