Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export env var in the doc build #177

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Export env var in the doc build #177

merged 6 commits into from
Apr 25, 2024

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Apr 25, 2024 •
edited
Loading

Need to export the TORCHAO_VERSION_DOCS env in the build job so it's correctly propagated to the make html command.
This:

Running Sphinx v5.0.0
torchao_version_docs: refs/pull/177/merge
Version: main

Will become this on tags and release:

Running Sphinx v5.0.0
torchao_version_docs: refs/heads/release/0.1
Version: 0.1

Running Sphinx v5.0.0
torchao_version_docs: refs/tags/v0.1.0-rc2
Version: 0.1

This will be reflected in the left nav version dropdown.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@svekars svekars marked this pull request as ready for review April 25, 2024 21:04
@svekars svekars merged commit a3b954a into main Apr 25, 2024
13 checks passed
@svekars svekars deleted the svekars-patch-3 branch April 25, 2024 21:22
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
@svekars
Export env var in the doc build (pytorch#177)
dbd5097 
* Export env var in the doc build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svekars @cpuhrsch @facebook-github-bot