Add test for torch.export.export #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
May 3, 2024
test/integration/test_integration.py
Outdated
|
|
||
| if test_device == "cuda" and not torch.cuda.is_available(): | ||
| self.skipTest(f"Need CUDA available.") | ||
| if test_device == "cuda" and torch.cuda.is_available() and test_dtype == torch.bfloat16 and torch.cuda.get_device_capability() < (8, 0): |
There was a problem hiding this comment.
more of a nit but can you move these to the top of the function with unittest.skipif() I'm not used to reading a function to figure out what gets skipped
There was a problem hiding this comment.
right, these are kind of deepened on the args, we do have a (brutal) helper function that does this, but I need to think about how we can make that more robust: https://github.com/pytorch/ao/blob/main/test/integration/test_integration.py#L98
I can refactor this one to use that helper for now though
Merged
Summary: att Test Plan: python test/integration/test_integration/py -k TestExport Reviewers: Subscribers: Tasks: Tags:
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: att Test Plan: python test/integration/test_integration/py -k TestExport Reviewers: Subscribers: Tasks: Tags: Co-authored-by: Mark Saroufim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att
Test Plan:
python test/integration/test_integration/py -k TestExport
Reviewers:
Subscribers:
Tasks:
Tags: