Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nightly build instructions #334

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update nightly build instructions #334

merged 2 commits into from
Jun 7, 2024

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented Jun 7, 2024 •
edited
Loading

Test plan

Important part is the date: Successfully installed torchao-nightly-2024.6.7+cu124

(ao) [[email protected] ~]$ pip install --pre torchao-nightly --index-url https://download.pytorch.org/whl/nightly/ 
Looking in indexes: https://download.pytorch.org/whl/nightly/
Collecting torchao-nightly
  Downloading https://download.pytorch.org/whl/nightly/cu124/torchao_nightly-2024.6.7%2Bcu124-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.0/1.0 MB 3.1 MB/s eta 0:00:00
Requirement already satisfied: torch in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (2.3.1)
Requirement already satisfied: numpy in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (1.26.4)
Requirement already satisfied: sentencepiece in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (0.2.0)
Requirement already satisfied: packaging in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (24.0)
Requirement already satisfied: expecttest in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (0.2.1)
Requirement already satisfied: hypothesis in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torchao-nightly) (6.103.1)
Requirement already satisfied: attrs>=22.2.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from hypothesis->torchao-nightly) (23.2.0)
Requirement already satisfied: sortedcontainers<3.0.0,>=2.1.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from hypothesis->torchao-nightly) (2.4.0)
Requirement already satisfied: exceptiongroup>=1.0.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from hypothesis->torchao-nightly) (1.2.1)
Requirement already satisfied: filelock in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (3.14.0)
Requirement already satisfied: typing-extensions>=4.8.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (4.12.1)
Requirement already satisfied: sympy in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (1.12.1)
Requirement already satisfied: networkx in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (3.3)
Requirement already satisfied: jinja2 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (3.1.4)
Requirement already satisfied: fsspec in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (2024.6.0)
Requirement already satisfied: nvidia-cuda-nvrtc-cu12==12.1.105 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.105)
Requirement already satisfied: nvidia-cuda-runtime-cu12==12.1.105 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.105)
Requirement already satisfied: nvidia-cuda-cupti-cu12==12.1.105 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.105)
Requirement already satisfied: nvidia-cudnn-cu12==8.9.2.26 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (8.9.2.26)
Requirement already satisfied: nvidia-cublas-cu12==12.1.3.1 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.3.1)
Requirement already satisfied: nvidia-cufft-cu12==11.0.2.54 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (11.0.2.54)
Requirement already satisfied: nvidia-curand-cu12==10.3.2.106 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (10.3.2.106)
Requirement already satisfied: nvidia-cusolver-cu12==11.4.5.107 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (11.4.5.107)
Requirement already satisfied: nvidia-cusparse-cu12==12.1.0.106 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.0.106)
Requirement already satisfied: nvidia-nccl-cu12==2.20.5 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (2.20.5)
Requirement already satisfied: nvidia-nvtx-cu12==12.1.105 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (12.1.105)
Requirement already satisfied: triton==2.3.1 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from torch->torchao-nightly) (2.3.1)
Requirement already satisfied: nvidia-nvjitlink-cu12 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from nvidia-cusolver-cu12==11.4.5.107->torch->torchao-nightly) (12.5.40)
Requirement already satisfied: MarkupSafe>=2.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from jinja2->torch->torchao-nightly) (2.1.5)
Requirement already satisfied: mpmath<1.4.0,>=1.1.0 in ./anaconda3/envs/ao/lib/python3.10/site-packages (from sympy->torch->torchao-nightly) (1.3.0)
Installing collected packages: torchao-nightly
Successfully installed torchao-nightly-2024.6.7+cu124

Importing the package succeeds

(ao) [[email protected] ~]$ python
Python 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torchao
>>>

If someone else wants to import torchao in their requirements.txt and use the nightlies they would have

# in requirements.txt
-index-url https://download.pytorch.org/whl/nightly/
torchao-nightly

Although not sure how this would work with a pyproject.toml based flow, I know that's considered more modern but seems like there's no way I can find to set an extra index up without the help of something like poetry

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/334

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f24df09 with merge base ff42c85 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@msaroufim msaroufim requested a review from andrewor14 June 7, 2024 05:41
@msaroufim msaroufim requested review from huydhn and atalman June 7, 2024 06:19
@msaroufim msaroufim merged commit c8d9fa5 into main Jun 7, 2024
12 of 13 checks passed
@malfet
Copy link

malfet commented Jun 7, 2024

https://download.pytorch.org/whl/nightly/ feels like a wrong location, it should be accelerator specific i.e. `https://download.pytorch.org/whl/nightly/cu121

dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
@msaroufim
Update nightly build instructions (pytorch#334)
199ac0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@huydhn huydhn Awaiting requested review from huydhn

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msaroufim @malfet @andrewor14 @facebook-github-bot