Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for map_location="cpu" #497

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

jerryzh168
Copy link
Contributor

Summary:
torchtune is using torch.load(file_name, map_location="cpu", mmap=True), so we add a test to make sure this works with tensor subclass API

Test Plan:
python test/quantization/test_quant_api.py -k test_quantized_tensor_subclass_save_load_map_location

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jul 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/497

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9da3032 with merge base 05038a1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2024
Summary:
torchtune is using torch.load(file_name, map_location="cpu", mmap=True), so we add a test
to make sure this works with tensor subclass API

Test Plan:
python test/quantization/test_quant_api.py -k test_quantized_tensor_subclass_save_load_map_location

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168 jerryzh168 merged commit 1029df3 into pytorch:main Jul 11, 2024
13 checks passed
@jerryzh168 jerryzh168 deleted the map_location branch July 11, 2024 23:47
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
Summary:
torchtune is using torch.load(file_name, map_location="cpu", mmap=True), so we add a test
to make sure this works with tensor subclass API

Test Plan:
python test/quantization/test_quant_api.py -k test_quantized_tensor_subclass_save_load_map_location

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants