[test] Fix regression tests #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Torch 2.2 is compiled with numpy 1.x, but when we `pip install -r requirements-dev.txt` we download a higher version of numpy (2.0) This causes an error with the .numpy() calls and importing torch in general. I don't think we want to pin the versions in requirements-dev.txt, so instead I added a pin to the numpy version in the specific torch spec, so it'll only run for 2.2. PT 2.3+ support numpy 2.0+ which is why those test don't fail. Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/537
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit de6b95c with merge base 5787e9e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
approved these changes
Jul 24, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Fix regression tests Summary: Torch 2.2 is compiled with numpy 1.x, but when we `pip install -r requirements-dev.txt` we download a higher version of numpy (2.0) This causes an error with the .numpy() calls and importing torch in general. I don't think we want to pin the versions in requirements-dev.txt, so instead I added a pin to the numpy version in the specific torch spec, so it'll only run for 2.2. PT 2.3+ support numpy 2.0+ which is why those test don't fail. Test Plan: Reviewers: Subscribers: Tasks: Tags: * use == and specify for CPU as well * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Torch 2.2 is compiled with numpy 1.x, but when we
pip install -r requirements-dev.txtwe download a higher version of numpy (2.0)This causes an error with the .numpy() calls and importing torch in general. I don't think we want to pin the versions in requirements-dev.txt, so instead I pinned the numpy version when we pin the torch version, so it'll only run for 2.2.
PT 2.3+ support numpy 2.0+ which is why those test don't fail.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: