The links on the Byte-Sized tutorials all return 404.

[CBrauer]

Please fix the links on the "Byte-Sized Tutorials". All I get is 404!

[Balandat]

@CBrauer I just checked, the links work fine for me on both the "latest" and "stable" version of botorch.org.

How / where exactly are you trying to access these? Does https://botorch.org/v/latest/tutorials/fit_model_with_torch_optimizer work?

If not, what browser are you using?

[CBrauer]

I was on the GitHub site, not your web site. From: Max Balandat <[email protected]> Sent: Wednesday, October 23, 2019 11:39 AM To: pytorch/botorch <[email protected]> Cc: Charles Brauer <[email protected]>; Mention <[email protected]> Subject: Re: [pytorch/botorch] The links on the Byte-Sized tutorials all return 404. (#300) @CBrauer <https://github.com/CBrauer> I just checked, the links work fine for me on both the "latest" and "stable" version of botorch.org. How / where exactly are you trying to access these? Does https://botorch.org/v/latest/tutorials/fit_model_with_torch_optimizer work? If not, what browser are you using? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#300?email_source=notifications&email_token=AAKBS4TFDYICLYYPMLN4OIDQQCK3ZA5CNFSM4JEG3BJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCOLUA#issuecomment-545580496> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKBS4TUH3FVJNEDLQ3YTULQQCK3ZANCNFSM4JEG3BJA> . <https://github.com/notifications/beacon/AAKBS4RIQHROUX2YNXPUKR3QQCK3ZA5CNFSM4JEG3BJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCOLUA.gif>

[Balandat]

Which github site? I still don't understand where/how you're trying to access the tutorials. Can you provide a link?

[CBrauer]

Go to https://pytorch.org/botorch/tutorials/. Click on the “Fitting a model using torch.optum” link. From: Max Balandat <[email protected]> Sent: Wednesday, October 23, 2019 12:47 PM To: pytorch/botorch <[email protected]> Cc: Charles Brauer <[email protected]>; Mention <[email protected]> Subject: Re: [pytorch/botorch] The links on the Byte-Sized tutorials all return 404. (#300) Which github site? I still don't understand where/how you're trying to access the tutorials. Can you provide a link? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#300?email_source=notifications&email_token=AAKBS4XKVZGXSYYIM2LD6P3QQCS2RA5CNFSM4JEG3BJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCUXUY#issuecomment-545606611> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKBS4XRNEJK4GI7CN53VV3QQCS2RANCNFSM4JEG3BJA> . <https://github.com/notifications/beacon/AAKBS4QDOOGGK6VE5C6PCSDQQCS2RA5CNFSM4JEG3BJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCUXUY.gif>

[Balandat]

Ahh ok, I see - the https://pytorch.org/botorch/ site is not meant to be accessed directly, please use the public site https://botorch.org.

Some background: Unfortunately there are some relative link issues that Docusaurus (the tool we use for building the website) is not able to handle well in conjunction with redirects. Quoting @Jakepodell here:

A lot of how docusaurus links assets is heavily reliant on that baseUrl field, which cannot be relative to to the current directory but rather has to be relative to the top-level hostname.
See facebook/docusaurus#448, where they admit I think at this point our architecture relies a lot on baseUrl and supporting this will be quite a huge refactor. I personally feel the effort is better spent elsewhere.
The baseUrl also cannot be a fully absolute path, like 'https://botorch.org". The result of all these findings is basically that docusarus is not set up to support the same site existing at two different paths relative to their top-level hostnames.

Unfortunately it doesn't seem that docusaurus is planning to fix this anytime soon, so for now we'll just have to try to keep people away from the https://pytorch.org/botorch/ and possibly move away from docusaurus down the road (this doesn't seem to be addressed in docusaurus 2.0 either).

cc @JoelMarcey

[JoelMarcey]

This is actually not fully a Docusaurus issue, tbh, if at all really. It is how we have some of our domains setup internally and via the CDN we use.

For example, if you go to https://facebook.github.io/docusaurus, you will see it automatically redirects to https://docusaurus.io. And, of course, the Docusaurus site uses Docusaurus. Hydra is another example --- https://facebookresearch.github.io/hydra ==> https://cli.dev. It also uses Docusaurus. The way we have those domains setup are a little different, allowing for redirecting to work correctly.

This is more of fixing some of the underlying infrastructure of the configuration of some of our domains, imho.

[endiliey]

I think its because this repo didnt set a CNAME on siteConfig. Thats why it happens. Maybe its worth a try to set CNAME on siteConfig.js so that the built static files will have CNAME like https://github.com/facebookresearch/hydra/blob/gh-pages/CNAME

[JoelMarcey]

@endiliey that would be the normal course of action, yes. Like we do for Docusaurus and Hydra in my examples above. But in this case, the way we have our domains set up, it will cause a permanent redirect. (You could test it I suppose, but I am 99% sure I am right here)

That said, remembering a conversation with @zpao, we may just need to point out internal domain directly to GitHub instead of our CDN and figure another way to get a cert going.

_{Sent with GitHawk}

[Balandat]

But in this case, the way we have our domains set up, it will cause a permanent redirect. (You could test it I suppose, but I am 99% sure I am right here)

Yes, I did test this, browser quits b/c of too many redirects.

[Balandat]

Reopening until it is verified that this works on the "latest" version of the site (will be auto-deployed over night).

[Balandat]

This in fact does not work properly with the versioned site. If you go to https://pytorch.org/botorch/v/latest/index.html then the site realizes that you are in the wrong place, but the redirect takes you to https://botorch.org/v/latest/v/latest/index.html (instead of https://botorch.org/v/latest/index.html), yielding a 404.

[zpao]

Hmm, your versioned docs are … special I suppose. baseURL in your siteConfig is just / which would work. But seems like these docs are spacial and you'll want to do more in here: https://github.com/pytorch/botorch/blob/master/website/core/Footer.js#L100

[Balandat]

Indeed. I guess we should handle both the case of /botorch/ and /botorch/v/**/.

[Balandat]

deployed new website for the stable version, this issue is mitigated now