Provide more informative warning messages in InputDataWarning
#2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 16946 16946
=======================================
Hits 16944 16944
Misses 2 2 ☔ View full report in Codecov by Sentry. |
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 26, 2024
Summary: X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Aug 26, 2024
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
force-pushed
the
export-D61797434
branch
from
494a616
to
30b08e0
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 26, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 26, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 26, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Aug 28, 2024
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
force-pushed
the
export-D61797434
branch
from
30b08e0
to
1b0fee7
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 28, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Aug 28, 2024
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
force-pushed
the
export-D61797434
branch
from
1b0fee7
to
f51ce3f
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 28, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Aug 28, 2024
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
force-pushed
the
export-D61797434
branch
from
f51ce3f
to
3cd492d
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 28, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Aug 28, 2024
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
ltiao
force-pushed
the
export-D61797434
branch
from
3cd492d
to
baf27b4
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 28, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
…rch#2489) Summary: X-link: facebook/Ax#2713 Pull Request resolved: pytorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request was exported from Phabricator. Differential Revision: D61797434 |
ltiao
force-pushed
the
export-D61797434
branch
from
baf27b4
to
dc61aa2
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Aug 28, 2024
…book#2713) Summary: Pull Request resolved: facebook#2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Differential Revision: D61797434
|
This pull request has been merged in cdcd149. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: #2713 X-link: pytorch/botorch#2489 Provide more informative warning messages when `InputDataWarning`s are raised to specify whether it pertains to input features or output targets. Updated unit tests accordingly to ensure coverage. Reviewed By: Balandat Differential Revision: D61797434 fbshipit-source-id: 494e5ce0e4713796f1836406d2a89c7138dba667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Provide more informative warning messages when
InputDataWarnings are raised to specify whether it pertains to input features or output targets.Updated unit tests accordingly to ensure coverage.
Differential Revision: D61797434