Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manywheel] Add Python-3.12.0b2 #1427

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[Manywheel] Add Python-3.12.0b2 #1427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/install_cpython.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ PYTHON_DOWNLOAD_URL=https://www.python.org/ftp/python
GET_PIP_URL=https://bootstrap.pypa.io/get-pip.py

# Python versions to be installed in /opt/$VERSION_NO
CPYTHON_VERSIONS=${CPYTHON_VERSIONS:-"3.7.5 3.8.1 3.9.0 3.10.1 3.11.0"}
CPYTHON_VERSIONS=${CPYTHON_VERSIONS:-"3.7.5 3.8.1 3.9.0 3.10.1 3.11.0 3.12.0"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this change but according to our policy, If these represent the lowest patch version we support for each, we can bump the patch versions all the way to the first non-bugfix version. It doesn't change much usually but I wonder how strict we want to be to our rule?

Copy link
Contributor Author

@malfet malfet Jun 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've though about updating those when pushing the change, but:

  • Those are not really min version we support, but rather the versions we use to drive the build
  • CPython API is really stable, so it shouldn't matter much
  • But on the Python side there are some BC-breaking changes even between patch revisions

Also, I wonder if we should remove 3.7.5, as 3.7 have reached EOL. Will submit a followup PR later today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have 3.7 builds so it can be safely removed I think yes (maybe some other Nova users still use it?)

I agree that in general patch version doesn't matter but there can be BC-breaking change in "bugfix" versions (though it is very rare, it did happen for 3.7 IIRC).
My thinking was more: as most things, the real rule is defined in code. And I think the rule of not supporting old bugfix patch version is important for our code sanity so we should enforce it here. Maybe we want a process to make sure this list is up to date wrt to our python version rules.


function check_var {
if [ -z "$1" ]; then
Expand Down Expand Up @@ -64,6 +64,10 @@ function build_cpython {
check_var $py_ver
check_var $PYTHON_DOWNLOAD_URL
local py_ver_folder=$py_ver
# Only b2 version of 3.12 is available right now
if [ "$py_ver" = "3.12.0" ]; then
py_ver=$py_ver"b2"
fi
wget -q $PYTHON_DOWNLOAD_URL/$py_ver_folder/Python-$py_ver.tgz
do_cpython_build $py_ver none
rm -f Python-$py_ver.tgz
Expand Down