Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ROCm5.6 for nightly wheels #1442

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add support for ROCm5.6 for nightly wheels #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65cef31
Add msccl-algorithms directory to PyTorch wheel
jithunnair-amd Jun 12, 2023
f3d1905
Add hipblaslt dependency for ROCm5.6 onwards
jithunnair-amd Jun 30, 2023
507018d
Update build_all_docker.sh to ROCm5.6
jithunnair-amd Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libtorch/build_all_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ for cuda_version in 12.1 11.8; do
GPU_ARCH_TYPE=cuda GPU_ARCH_VERSION="${cuda_version}" "${TOPDIR}/libtorch/build_docker.sh"
done

for rocm_version in 5.4.2 5.5; do
for rocm_version in 5.5 5.6; do
GPU_ARCH_TYPE=rocm GPU_ARCH_VERSION="${rocm_version}" "${TOPDIR}/libtorch/build_docker.sh"
done
2 changes: 1 addition & 1 deletion manywheel/build_all_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ for cuda_version in 12.1 11.8; do
MANYLINUX_VERSION=2014 GPU_ARCH_TYPE=cuda GPU_ARCH_VERSION="${cuda_version}" "${TOPDIR}/manywheel/build_docker.sh"
done

for rocm_version in 5.4.2 5.5; do
for rocm_version in 5.5 5.6; do
GPU_ARCH_TYPE=rocm GPU_ARCH_VERSION="${rocm_version}" "${TOPDIR}/manywheel/build_docker.sh"
MANYLINUX_VERSION=2014 GPU_ARCH_TYPE=rocm GPU_ARCH_VERSION="${rocm_version}" "${TOPDIR}/manywheel/build_docker.sh"
done
13 changes: 13 additions & 0 deletions manywheel/build_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ ROCM_SO_FILES=(
"libroctx64.so"
)

if [[ $ROCM_INT -ge 50600 ]]; then
ROCM_SO_FILES+=("libhipblaslt.so")
fi

if [[ $ROCM_INT -lt 50500 ]]; then
ROCM_SO_FILES+=("librocfft-device-0.so")
ROCM_SO_FILES+=("librocfft-device-1.so")
Expand Down Expand Up @@ -198,8 +202,17 @@ if [[ $ROCM_INT -ge 50500 ]]; then

DEPS_AUX_SRCLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_SRC/})
DEPS_AUX_DSTLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_DST/})
elif [[ $ROCM_INT -ge 50600 ]]; then
# RCCL library files
RCCL_SHARE_SRC=$ROCM_HOME/lib/msccl-algorithms
RCCL_SHARE_DST=lib/msccl-algorithms
RCCL_SHARE_FILES=($(ls $RCCL_SHARE_SRC))

DEPS_AUX_SRCLIST+=(${RCCL_SHARE_FILES[@]/#/$RCCL_SHARE_SRC/})
DEPS_AUX_DSTLIST+=(${RCCL_SHARE_FILES[@]/#/$RCCL_SHARE_DST/})
fi


echo "PYTORCH_ROCM_ARCH: ${PYTORCH_ROCM_ARCH}"

SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"
Expand Down