Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Add CI for check_binary.sh changes #1637

Merged
merged 6 commits into from
Dec 10, 2023
Merged

[BE] Add CI for check_binary.sh changes #1637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92ca9e4
[BE] Add some test automation for check_binary.sh
malfet Dec 10, 2023
cd6af55
That is like that
malfet Dec 10, 2023
22a0e49
Will it work like that
malfet Dec 10, 2023
bc90f7c
And test on CUDA as well
malfet Dec 10, 2023
324a6b1
And another fix
malfet Dec 10, 2023
e4fb930
Better handling for relative paths
malfet Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/test-check-binary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Test check_binary

on:
push:
branches:
- main
pull_request:
paths:
- .github/workflows/test-check-binary.yml
- check_binary.sh
- test/smoke_test/smoke_test.py

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' }}
cancel-in-progress: true

jobs:
check_binary_linux_cpu:
name: Test check_binary.sh for Linux CPU
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
with:
repository: "pytorch/builder"
docker-image: python:3.11
script: |
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
DESIRED_PYTHON=3.11 DESIRED_CUDA=cpu PACKAGE_TYPE=manywheel ./check_binary.sh

check_binary_linux_cuda:
name: Test check_binary.sh for Linux CUDA
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
with:
repository: "pytorch/builder"
runner: linux.4xlarge.nvidia.gpu
docker-image: python:3.11
script: |
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121
DESIRED_PYTHON=3.11 DESIRED_CUDA=cu121 PACKAGE_TYPE=manywheel ./check_binary.sh
2 changes: 1 addition & 1 deletion check_binary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ setup_link_flags () {
fi
}

TEST_CODE_DIR="$(dirname ${BASH_SOURCE[0]})/test_example_code"
TEST_CODE_DIR="$(dirname $(realpath ${BASH_SOURCE[0]}))/test_example_code"
build_and_run_example_cpp () {
if [[ "$DESIRED_DEVTOOLSET" == *"cxx11-abi"* ]]; then
GLIBCXX_USE_CXX11_ABI=1
Expand Down