Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda Windows smoke_test #1687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mantaionut
Copy link
Contributor

@mantaionut mantaionut commented Jan 25, 2024

PYTORCH_BUILD_VERSION can be different then the downloaded artifact since its using the DATE.

Saw some failures in the windows-binary-conda test pytorch nightly just like https://ossci-raw-job-status.s3.amazonaws.com/log/20797350508.
The issue is caused by using PYTORCH_BUILD_VERSION to install that version however if the build happens the day before it will download for example pytorch-2.3.0.dev20240123-py3.10_cuda11.8_cudnn8_0.tar.bz2 while PYTORCH_BUILD_VERSION will be 2.3.0.dev20240124.
So I removed the PYTORCH_BUILD_VERSION from conda install and instead parse the downloaded artifact name and get its version and use it in conda install
This PR is tested by pytorch/pytorch#118275.

@mantaionut mantaionut marked this pull request as draft January 25, 2024 22:12
PYTORCH_BUILD_VERSION can be different then the downloaded artifact
@mantaionut mantaionut marked this pull request as ready for review January 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants