Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin setuptools 72.1.0 #1995

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Pin setuptools 72.1.0 #1995

merged 2 commits into from
Sep 18, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Sep 18, 2024 •
edited
Loading

kit1980
kit1980 reviewed Sep 18, 2024
View reviewed changes
windows/condaenv.bat
if "%%v" == "3.11" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v
if "%%v" == "3.12" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v
if "%%v" == "3.13" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=2.0.1 pyyaml boto3 cmake ninja typing_extensions setuptools python=%%v
if "%%v" == "3.8" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy=1.11 pyyaml boto3 cmake ninja typing_extensions setuptools=72.1.0 python=%%v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need python 3.8?

@atalman atalman changed the title pin_setuptools_72.1.0 Pin setuptools 72.1.0 Sep 18, 2024
atalman
atalman commented Sep 18, 2024
View reviewed changes
windows/condaenv.bat Outdated Show resolved Hide resolved
@atalman atalman merged commit 65eb45c into main Sep 18, 2024
2 checks passed
@atalman atalman deleted the pin_setuptools_72.1.0 branch September 18, 2024 23:47
atalman added a commit that referenced this pull request Sep 23, 2024
@atalman
Pin setuptools=72.1.0 for conda builds
89d9a8c 
Same underlyning issue as wheel/libtorch build failure fixed by: #1995
@ratnampa ratnampa mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @kit1980 @malfet @facebook-github-bot