-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: add USE_SYSTEM_* options #153
Conversation
@malfet @Maratyszcza would either of you have the bandwidth to take a look at this? |
@ConnorBaker Looks good to me, though I wonder if |
9c8008f
to
4164fb9
Compare
Thank you for the feedback! I've addressed comments and force-pushed the changes. @malfet I think it makes sense to have @Maratyszcza are the names good now? Also (because I have multiple PRs open doing the same thing), would you recommend using that naming instead of |
@ConnorBaker I don't have a preference for |
Similar to the work done in pytorch/pytorch#37137, this adds the following CMake options:
USE_SYSTEM_LIBS
USE_SYSTEM_GOOGLEBENCHMARK
USE_SYSTEM_GOOGLETEST
This is particularly useful in the context of Nix, where we can build these libraries once and then re-use them elsewhere to avoid rebuilding vendors dependencies.