Revert "Make flatcc cross-compile deterministic (#4312)" #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15815dd, which broke the test-coreml-delegate job. Details in pytorch#4312 (comment)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4528
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5d30136 with merge base fbc183f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
@haowhsu-quic mind re-submiting again? We can add ciflow/trunk label to trigger this test
PR created with #4541, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 15815dd, which broke the test-coreml-delegate job. Details in #4312 (comment)