Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix test issue with recent MLfow #3277

Closed
vfdev-5 opened this issue Sep 3, 2024 · 1 comment · Fixed by #3280
Closed

[CI] Fix test issue with recent MLfow #3277

vfdev-5 opened this issue Sep 3, 2024 · 1 comment · Fixed by #3280

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 3, 2024

🐛 Bug description

These tests are failing for mlflow 2.16.0, let's fix our code to make these tests pass:

=========================== short test summary info ============================
FAILED tests/ignite/contrib/engines/test_common.py::test_setup_mlflow_logging - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_output_transform - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_metric_names - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_both - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_with_global_step_transform - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_with_global_step_from_engine - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_output_handler_state_attrs - ImportError: cannot import name '_VALID_PARAM_AND_METRIC_NAMES' from 'mlflow.utils.validation' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mlflow/utils/validation.py)
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_integration - mlflow.exceptions.MlflowException: Run '3ed0ca602f354d88a59b43a228752c55' not found
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_integration_as_context_manager - mlflow.exceptions.MlflowException: Run '3ed0ca602f354d88a59b43a228752c55' not found
FAILED tests/ignite/handlers/test_mlflow_logger.py::test_mlflow_bad_metric_name_handling - Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) were emitted.
 Emitted warnings: [].
======================== 10 failed, 1 warning in 4.77s =========================
Copy link

github-actions bot commented Sep 3, 2024

Hey 👋, I've just created a thread for this issue on PyTorch-Ignite Discord where you can quickly talk to the community on the topic.

🤖 This comment was automatically posted by Discuss on Discord

puhuk added a commit to puhuk/ignite that referenced this issue Sep 4, 2024
@puhuk puhuk mentioned this issue Sep 4, 2024
3 tasks
@vfdev-5 vfdev-5 closed this as completed in 653fb9e Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant