Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding max_iters as an optional arg in Engine run #1381

Merged
merged 34 commits into from
Nov 9, 2020
Merged

Adding max_iters as an optional arg in Engine run #1381

merged 34 commits into from
Nov 9, 2020

Commits on Oct 11, 2020

  1. initial draft, adding max_iters as optional args in run

    @thescripted
    thescripted committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    f661556 View commit details
    Browse the repository at this point in the history

  2. fixed typo

    @thescripted
    thescripted committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    0919761 View commit details
    Browse the repository at this point in the history

  3. minor bug fixes

    @thescripted
    thescripted committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    0389374 View commit details
    Browse the repository at this point in the history

  4. resolving failing tests

    @thescripted
    thescripted committed Oct 11, 2020
    Configuration menu
    Copy the full SHA
    8abbc63 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. fixed out-of-place conditional

    @thescripted
    thescripted committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    fdd01a1 View commit details
    Browse the repository at this point in the history

  2. typo fix

    @thescripted
    thescripted committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0db9761 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. updated docstring for 'run'

    @thescripted
    thescripted committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    4bf0a1d View commit details
    Browse the repository at this point in the history

  2. added initial tests

    @thescripted
    thescripted committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    8ba97cb View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Merge branch 'master' of https://github.com/pytorch/ignite into featu… 

    …re.max_iters
    @thescripted
    thescripted committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    b52ec66 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. (WIP) restructured creating a new state with max_iters

    @thescripted
    thescripted committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    da92e4b View commit details
    Browse the repository at this point in the history

  2. updated tests & docstrings

    @thescripted
    thescripted committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    b40a893 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. initial draft, adding max_iters as optional args in run

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4bba8cb View commit details
    Browse the repository at this point in the history

  2. fixed typo

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    0d6a4fb View commit details
    Browse the repository at this point in the history

  3. minor bug fixes

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    f353b05 View commit details
    Browse the repository at this point in the history

  4. resolving failing tests

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    548b334 View commit details
    Browse the repository at this point in the history

  5. fixed out-of-place conditional

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    2cb2393 View commit details
    Browse the repository at this point in the history

  6. typo fix

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4152796 View commit details
    Browse the repository at this point in the history

  7. updated docstring for 'run'

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    afb58fb View commit details
    Browse the repository at this point in the history

  8. added initial tests

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    c9eab3f View commit details
    Browse the repository at this point in the history

  9. (WIP) restructured creating a new state with max_iters

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    9f4fc06 View commit details
    Browse the repository at this point in the history

  10. updated tests & docstrings

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    f29267b View commit details
    Browse the repository at this point in the history

  11. added test to check _is_done

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4896079 View commit details
    Browse the repository at this point in the history

  12. updating engine loop condition

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    ea96a65 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'feature.max_iters' of https://github.com/thescripted/ig… 

    …nite into feature.max_iters
    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    d49cd50 View commit details
    Browse the repository at this point in the history

  14. autopep8 fix

    @thescripted @actions-user
    thescripted authored and actions-user committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    87fc6dd View commit details
    Browse the repository at this point in the history

  15. linting issues

    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    c17ab6c View commit details
    Browse the repository at this point in the history

  16. Merge branch 'feature.max_iters' of https://github.com/thescripted/ig… 

    …nite into feature.max_iters
    @thescripted
    thescripted committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    7ea52e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Merge branch 'master' into feature.max_iters

    @vfdev-5
    vfdev-5 authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    2a4efa9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Merge branch 'master' into feature.max_iters

    @thescripted
    thescripted authored Nov 3, 2020
    Configuration menu
    Copy the full SHA
    a2796cb View commit details
    Browse the repository at this point in the history

  2. fixed mypy errors

    @thescripted
    thescripted committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    1d1416b View commit details
    Browse the repository at this point in the history

  3. fixed formatting

    @thescripted
    thescripted committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    e019c0f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2020

  1. minor fix & add test for larger max_iters

    @thescripted
    thescripted committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    7444964 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature.max_iters

    @thescripted
    thescripted authored Nov 9, 2020
    Configuration menu
    Copy the full SHA
    25c4aa1 View commit details
    Browse the repository at this point in the history

  3. removed unused typechecking

    @thescripted
    thescripted committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    c179b9d View commit details
    Browse the repository at this point in the history