Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] migrate docs build to github actions #1457

Merged
merged 18 commits into from
Nov 25, 2020
Merged

[ci] migrate docs build to github actions #1457

merged 18 commits into from
Nov 25, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 11, 2020

Part of #1442

Description: migrate docs build to github actions

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 11, 2020

There are some warnings in the logs. logo is missing

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 23, 2020

@vfdev-5 does it look good to you?

vfdev-5
vfdev-5 reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ydcjeff

.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@ydcjeff ydcjeff requested a review from vfdev-5 November 24, 2020 14:58
vfdev-5
vfdev-5 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydcjeff thanks for the PR !

@vfdev-5 vfdev-5 merged commit 10a0a6e into pytorch:master Nov 25, 2020
@ydcjeff ydcjeff deleted the docs branch November 25, 2020 01:48
@vfdev-5 vfdev-5 mentioned this pull request Dec 3, 2020
Closed
1 task
@vfdev-5 vfdev-5 mentioned this pull request Dec 17, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @vfdev-5