-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] migrate stable binaries release to github actions #1458
Conversation
@vfdev-5 can this workflow works with release? or do we need to provide |
@ydcjeff thanks for the PR ! Migrating binary releases is very important and should be carefully done and tested. Just few remarks, I already provided a script for conda here: https://github.com/pytorch/ignite/blob/master/conda.recipe/build_and_upload.sh |
@vfdev-5 okay now? |
@vfdev-5 ready to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let me check everything on my fork before merging to the master
@vfdev-5 any chance we can merge this? |
@ydcjeff yes, it will be merged once I have tested it on my fork by creating a tag and launching release process. Unfortunately, I hadn't yet time to work on that. |
Part of #1442
Description: migrate binaries release to github actions
Check list: