Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] migrate stable binaries release to github actions #1458

Merged
merged 19 commits into from
Dec 17, 2020
Merged

[ci] migrate stable binaries release to github actions #1458

merged 19 commits into from
Dec 17, 2020

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 12, 2020

Part of #1442

Description: migrate binaries release to github actions

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 12, 2020

@vfdev-5 can this workflow works with release? or do we need to provide tags?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Nov 12, 2020

@ydcjeff thanks for the PR ! Migrating binary releases is very important and should be carefully done and tested. Just few remarks, I already provided a script for conda here: https://github.com/pytorch/ignite/blob/master/conda.recipe/build_and_upload.sh
and for conda and pypi it should done the same as here : https://github.com/pytorch/ignite/blob/master/.github/workflows/binaries-nightly-release.yml

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 12, 2020

@vfdev-5 okay now?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 24, 2020

@vfdev-5 ready to review!

@vfdev-5 vfdev-5 changed the title [ci] migrate binaries release to github actions [ci] migrate stable binaries release to github actions Nov 24, 2020
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me check everything on my fork before merging to the master

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Dec 6, 2020

@vfdev-5 any chance we can merge this?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Dec 6, 2020

@ydcjeff yes, it will be merged once I have tested it on my fork by creating a tag and launching release process. Unfortunately, I hadn't yet time to work on that.

@vfdev-5 vfdev-5 merged commit 0788f2a into pytorch:master Dec 17, 2020
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Dec 17, 2020

Checked here: https://github.com/vfdev-5/ignite/actions?query=workflow%3A%22Stable+Releases%22

@ydcjeff ydcjeff deleted the deploy branch December 18, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants