-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global boolean for controlling whether to record concrete shapes or not #101043
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101043
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4f1fcbb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D45680162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
023ffab
to
643ed13
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D45680162 |
643ed13
to
9075f59
Compare
9075f59
to
1938122
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
1938122
to
aee2059
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
aee2059
to
776908b
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
776908b
to
ea2ef9c
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
…or not (pytorch#101043) Summary: Pull Request resolved: pytorch#101043 We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact. Test Plan: Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to `pytorch/kineto:pytorch_record_concrete_inputs`; before, it returns true; after, it returns false. Note that D45681838 had to add `service` on the main function. That's because we need to `initFacebook` in order to use jks. Reviewed By: aaronenyeshi Differential Revision: D45680162 fbshipit-source-id: ef2bc60bc688db8143a82c8423d14b20b3a58155
ea2ef9c
to
4f1fcbb
Compare
This pull request was exported from Phabricator. Differential Revision: D45680162 |
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: We don't think the performance impact of recording concrete shapes is significant; but it's good to have a knob for turning it off quickly in case it has a large performance impact.
Test Plan:
Ran D45681838. It prints the state of that "concrete inputs" boolean. I ran it before and after canarying a change to
pytorch/kineto:pytorch_record_concrete_inputs
; before, it returns true; after, it returns false.Note that D45681838 had to add
service
on the main function. That's because we need toinitFacebook
in order to use jks.Differential Revision: D45680162