Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Detect None constant during jit scalar type analysis #101608

Closed
wants to merge 1 commit into from
Closed

[ONNX] Detect None constant during jit scalar type analysis #101608

wants to merge 1 commit into from

Conversation

thiagocrepaldi
Copy link
Collaborator

Fixes #97987

@pytorch-bot
Copy link

pytorch-bot bot commented May 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101608

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1f6dd62:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label May 16, 2023
@thiagocrepaldi thiagocrepaldi added module: onnx Related to torch.onnx topic: bug fixes topic category labels May 16, 2023
@thiagocrepaldi thiagocrepaldi mentioned this pull request May 16, 2023
Closed
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 17, 2023
@thiagocrepaldi
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@thiagocrepaldi thiagocrepaldi deleted the thiagofx/fix-97987 branch October 31, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

@abock abock Awaiting requested review from abock

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YoloV7 ONNX export fails with RuntimeError: r INTERNAL ASSERT FAILED at jit_type_base.h:549
5 participants
@thiagocrepaldi @pytorchmergebot @titaiwangms @pytorchbot @drisspg