Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add more USE_SYSTEM_* options #104576

Closed

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Jul 4, 2023

Adds support for using the following:

  • USE_SYSTEM_FBGEMM
  • USE_SYSTEM_MKLDNN

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104576

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 882b86d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ConnorBaker ConnorBaker force-pushed the feat-more-use-system-options branch 3 times, most recently from 69aad5d to fd018d2 Compare July 4, 2023 20:47
@ConnorBaker ConnorBaker changed the title cmake: add USE_SYSTEM_{FBGEMM,NNPACK} cmake: add more USE_SYSTEM_* options Jul 4, 2023
@ConnorBaker ConnorBaker force-pushed the feat-more-use-system-options branch 19 times, most recently from ec5ed72 to 5edb1aa Compare July 5, 2023 06:51
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 8, 2023
@github-actions github-actions bot closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants