Update sparse semi-structured linear operator #104608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104608
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 58206bc: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
alexsamardzic
added a commit
that referenced
this pull request
Jul 4, 2023
ghstack-source-id: 379592d0bd623e5406e3b323b76ad1053103c7cd Pull Request resolved: #104608
alexsamardzic
added
module: sparse
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
|
Just removed the code doing dense->(sparse,meta) conversion, thus sparse semi-structured linear operator simplified (renamed, for consistency, too). |
alexsamardzic
added a commit
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 8129f2aaefe68e8b8d20f90c2a7df87e187c4454 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 5, 2023
ghstack-source-id: 0f87cf5922e7c4b1fe733f50cbd627d072f0ea11 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 6, 2023
ghstack-source-id: 64542b7286697baff825977c941db833ab9219f9 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 6, 2023
ghstack-source-id: 21c50a18fea6990437f99a4f0b2aba1cb7532a80 Pull Request resolved: #104608
alexsamardzic
added a commit
that referenced
this pull request
Jul 6, 2023
ghstack-source-id: 21c50a18fea6990437f99a4f0b2aba1cb7532a80 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 6, 2023
ghstack-source-id: ce61dc5e4f111301db1307528d8e4488afd80112 Pull Request resolved: #104608
alexsamardzic
added a commit
that referenced
this pull request
Jul 10, 2023
ghstack-source-id: ce61dc5e4f111301db1307528d8e4488afd80112 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 10, 2023
ghstack-source-id: f5f44ede724d761a608a736e84934ae64467e683 Pull Request resolved: #104608
alexsamardzic
added a commit
that referenced
this pull request
Jul 11, 2023
ghstack-source-id: f5f44ede724d761a608a736e84934ae64467e683 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 11, 2023
ghstack-source-id: f6305175b1584807988dc4fd3ac9b60d0dd8cabb Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 11, 2023
ghstack-source-id: cff55ce35a9967f05ef0229d876db0ab364bd1ab Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
cpuhrsch
reviewed
Jul 13, 2023
| @@ -300,7 +300,7 @@ To use these ops, simply pass the output of ``to_sparse_semi_structured(tensor)` | |||
| >>> torch.allclose(c, torch.mm(a_sparse, b)) | |||
| True | |||
|
|
|||
| Under the hood, SparseSemiStructuredTensor will call ``torch._structured_sparse_linear`` for accelerated inference using CUTLASS sparse kernels. | |||
There was a problem hiding this comment.
We can remove this entirely. We don't document private functions.
cpuhrsch
approved these changes
Jul 13, 2023
alexsamardzic
added a commit
that referenced
this pull request
Jul 13, 2023
ghstack-source-id: 0f3a2b6620a2fcd5652828e48a5e086bfeb7b519 Pull Request resolved: #104608
cc nikitaved pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
alexsamardzic
added a commit
that referenced
this pull request
Jul 13, 2023
ghstack-source-id: c3eb18fd8c02210f308fc3bd948bb74ce6ba79b1 Pull Request resolved: #104608
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @nikitaved @pearu @cpuhrsch @amjames @bhosmer