Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCP] Add documentation for HSDP saving using DCP #104810

Closed
wants to merge 1 commit into from
Closed

[DCP] Add documentation for HSDP saving using DCP #104810

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Jul 7, 2023

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104810

Note: Links to docs will display an error until the docs builds have been completed.

❌ 21 New Failures

As of commit 471d681:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review July 7, 2023 23:39
@wz337 wz337 requested a review from kumpera July 7, 2023 23:43
@fduwjj fduwjj added the better-engineering Relatively self-contained tasks for better engineering contributors label Jul 8, 2023
fduwjj
fduwjj approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wz337
Copy link
Contributor Author

wz337 commented Jul 9, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_docuementation_for_hsdp_saving onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_docuementation_for_hsdp_saving && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the add_docuementation_for_hsdp_saving branch from 262dd41 to b13cfa0 Compare July 9, 2023 00:39
@wz337
Copy link
Contributor Author

wz337 commented Jul 10, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased add_docuementation_for_hsdp_saving onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_docuementation_for_hsdp_saving && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the add_docuementation_for_hsdp_saving branch from b13cfa0 to 471d681 Compare July 10, 2023 04:31
@wz337
Copy link
Contributor Author

wz337 commented Jul 10, 2023

@pytorchmergebot merge -f "unrelated test failure. the change is only on a docstring"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn added a commit to huydhn/pytorch that referenced this pull request Jul 10, 2023
@huydhn
Handle empty PR body in filter_test_configs
c5f3751 
This is a bug discovered by pytorch#104810
@huydhn huydhn mentioned this pull request Jul 10, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Jul 11, 2023
@huydhn @pytorchmergebot
Handle empty PR body in filter_test_configs (#104914)
26f7f47 
This is a bug discovered by #104810.  Basically, when the PR body is empty, GitHub API returns a None value, which is passed into `parse_reenabled_issues` causing it to fail.

### Testing

```
python3 .github/scripts/filter_test_configs.py \
  --workflow "pull" \
  --job-name "linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single-full-jit / filter," \
  --test-matrix "{ include: [ { config: 'default', shard: 1, num_shards: 1, runner: 'linux.2xlarge' }, ]}" \
  --pr-number "104810" \
  --tag "" \
  --event-name "pull_request" \
  --schedule "" \
  --branch ""
```

The command works correctly without failing now
Pull Request resolved: #104914
Approved by: https://github.com/clee2000
@carmocca carmocca mentioned this pull request Feb 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@kumpera kumpera Awaiting requested review from kumpera

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors Merged module: distributed_checkpoint release notes: distributed (checkpoint)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wz337 @pytorchmergebot @fduwjj