Fix get_current_graph_task_execution_order accumulate_grads ordering #105353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105353
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d6fffa7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…s ordering" [ghstack-poisoned]
soulitzer
added a commit
that referenced
this pull request
Jul 17, 2023
ghstack-source-id: c561766cd40615d9b1863b623b38b82d9b687dfd Pull Request resolved: #105353
albanD
approved these changes
Jul 17, 2023
soulitzer
added
release notes: autograd
|
@pytorchbot merge -f "Unrelated failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jansel
reviewed
Jul 18, 2023
| @@ -415,6 +415,8 @@ std::vector<Node*> get_current_graph_task_execution_order() { | |||
| const bool check_exec_info = !task->exec_info_.empty(); | |||
| std::vector<Node*> out{}; | |||
| std::unordered_set<Node*> seen{}; | |||
There was a problem hiding this comment.
With these changes, I think you might be able to delete the seen checking here.
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 18, 2023
…er (#105487) #105353 (comment) Pull Request resolved: #105487 Approved by: https://github.com/albanD, https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #105293