Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt2] add meta for cholesky #106115

Closed
wants to merge 3 commits into from

Conversation

nkaretnikov
Copy link
Collaborator

@nkaretnikov nkaretnikov commented Jul 27, 2023

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106115

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4a9ec7d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nkaretnikov nkaretnikov added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category ciflow/inductor labels Jul 27, 2023
@nkaretnikov
Copy link
Collaborator Author

From the list in #105105.

Note: it's a deprecated op, so can be potentially removed, but I've just added a meta to avoid getting sidetracked.

squareCheckInputs(self, "cholesky")
return cloneBatchedColumnMajor(self)


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See cholesky in aten/src/ATen/native/BatchLinearAlgebra.cpp

nkaretnikov added a commit that referenced this pull request Jul 27, 2023
ghstack-source-id: 7732ca3f4e2436109c848b1b76f62a453ce71f0e
Pull Request resolved: #106115
@nkaretnikov nkaretnikov marked this pull request as ready for review July 27, 2023 06:58
bobby-palmer pushed a commit to bobby-palmer/pytorch that referenced this pull request Jul 29, 2023
@facebook-github-bot facebook-github-bot deleted the gh/nkaretnikov/158/head branch August 2, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants