remove redundant dynamic_dim #107815

avikchaudhuri · 2023-08-23T20:14:35Z

Differential Revision: D48618472

cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov

pytorch-bot · 2023-08-23T20:14:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107815

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2fa0a8e with merge base 3875563 ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2023-08-23T20:15:05Z

This pull request was exported from Phabricator. Differential Revision: D48618472

angelayi · 2023-08-23T20:18:47Z

torch/fx/experimental/symbolic_shapes.py

            buf += f"\n```\ndef specify_constraints{str(signature)}:"
            buf += f"\n{indent}return ["
            print_results(
                grouped_dynamic_results,
                indent * 2,
-                lambda result: f"{remove_default_lower_bound(result)},",


Should remove_default_lower_bound be deleted then?

OOC, why is remove_default_lower_bound not called any more?

Moved its functionality upstream.

gmagogsfm · 2023-08-23T20:49:12Z

test/dynamo/test_export.py

+        a = torch.randn(3)
+        b = torch.randn(3)
+        with self.assertRaisesRegex(
+            torch._dynamo.exc.UserError, "\\[\n.*\n.*dynamic_dim.*==.*dynamic_dim.*\n.*\\]"


Optional nit:

This regex is overly specific, and it can become a "change detector". A better way is to detect that there is no patterns like "dynamic_dim(t, idx)," on its own line.

gmagogsfm · 2023-08-23T20:49:43Z

torch/fx/experimental/symbolic_shapes.py

@@ -1885,6 +1888,24 @@ def forced_specializations(self):
            if s in self._marked_dynamic
        ])

+    def remove_redundant_dynamic_results(self):


a bit of comment explaining its behavior would be nice.

yeah, added

gmagogsfm · 2023-08-23T20:50:59Z

torch/fx/experimental/symbolic_shapes.py

            buf += f"\n```\ndef specify_constraints{str(signature)}:"
            buf += f"\n{indent}return ["
            print_results(
                grouped_dynamic_results,
                indent * 2,
-                lambda result: f"{remove_default_lower_bound(result)},",


OOC, why is remove_default_lower_bound not called any more?

facebook-github-bot · 2023-08-23T20:54:00Z

This pull request was exported from Phabricator. Differential Revision: D48618472

facebook-github-bot · 2023-08-23T21:04:22Z

This pull request was exported from Phabricator. Differential Revision: D48618472

facebook-github-bot · 2023-08-23T21:37:57Z

This pull request was exported from Phabricator. Differential Revision: D48618472

avikchaudhuri · 2023-08-23T21:39:30Z

@pytorchbot merge

pytorchmergebot · 2023-08-23T21:41:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-08-23T21:41:28Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / workflow-checks / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

facebook-github-bot · 2023-08-23T21:44:58Z

This pull request was exported from Phabricator. Differential Revision: D48618472

Summary: Pull Request resolved: pytorch#107815 Test Plan: added test Differential Revision: D48618472 fbshipit-source-id: cfbeac2d3241380d331c07d3b37907798cb5b1df

facebook-github-bot · 2023-08-24T03:36:08Z

This pull request was exported from Phabricator. Differential Revision: D48618472

facebook-github-bot · 2023-08-24T03:42:48Z

This pull request was exported from Phabricator. Differential Revision: D48618472

avikchaudhuri · 2023-08-24T06:56:57Z

@pytorchbot merge

pytorchmergebot · 2023-08-24T06:58:42Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-08-24T06:58:51Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch rebase origin/main returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/dynamo/test_export.py
Auto-merging torch/fx/experimental/symbolic_shapes.py
CONFLICT (content): Merge conflict in torch/fx/experimental/symbolic_shapes.py
error: could not apply 90ebb6f2ca3... remove redundant dynamic_dim (#107815)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 90ebb6f2ca3... remove redundant dynamic_dim (#107815)

Details for Dev Infra team

Raised by workflow job

Summary: Pull Request resolved: pytorch#107815 Test Plan: added test Reviewed By: tugsbayasgalan Differential Revision: D48618472 fbshipit-source-id: 0078811f405fd8ad5827edffcdcd3943091db62b

facebook-github-bot · 2023-08-24T07:36:49Z

This pull request was exported from Phabricator. Differential Revision: D48618472

avikchaudhuri · 2023-08-24T07:38:04Z

@pytorchbot merge

pytorchmergebot · 2023-08-24T07:42:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added the release notes: fx release notes category label Aug 23, 2023

github-actions bot added module: dynamo ciflow/inductor labels Aug 23, 2023

facebook-github-bot added the fb-exported label Aug 23, 2023

avikchaudhuri requested review from gmagogsfm and tugsbayasgalan August 23, 2023 20:16

tugsbayasgalan approved these changes Aug 23, 2023

View reviewed changes

angelayi reviewed Aug 23, 2023

View reviewed changes

gmagogsfm approved these changes Aug 23, 2023

View reviewed changes

avikchaudhuri force-pushed the export-D48618472 branch from c4331fb to 9919454 Compare August 23, 2023 20:54

avikchaudhuri force-pushed the export-D48618472 branch from 9919454 to 7e80862 Compare August 23, 2023 21:04

avikchaudhuri force-pushed the export-D48618472 branch from 7e80862 to dd3decb Compare August 23, 2023 21:38

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 23, 2023

pytorchmergebot added the merging label Aug 23, 2023

pytorchmergebot removed the merging label Aug 23, 2023

avikchaudhuri force-pushed the export-D48618472 branch from dd3decb to 4763fed Compare August 23, 2023 21:45

avikchaudhuri force-pushed the export-D48618472 branch from 4763fed to 9363bef Compare August 24, 2023 03:36

avikchaudhuri force-pushed the export-D48618472 branch from 9363bef to eeb6ac6 Compare August 24, 2023 03:42

pytorchmergebot added the merging label Aug 24, 2023

pytorchmergebot removed the merging label Aug 24, 2023

remove redundant dynamic_dim (pytorch#107815)

2fa0a8e

Summary: Pull Request resolved: pytorch#107815 Test Plan: added test Reviewed By: tugsbayasgalan Differential Revision: D48618472 fbshipit-source-id: 0078811f405fd8ad5827edffcdcd3943091db62b

avikchaudhuri force-pushed the export-D48618472 branch from eeb6ac6 to 2fa0a8e Compare August 24, 2023 07:37

pytorchmergebot added the merging label Aug 24, 2023

pytorchmergebot added Merged and removed merging labels Aug 24, 2023

pytorchmergebot closed this in cf76938 Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove redundant dynamic_dim #107815

remove redundant dynamic_dim #107815

avikchaudhuri commented Aug 23, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 23, 2023 •

edited

Loading

facebook-github-bot commented Aug 23, 2023

angelayi Aug 23, 2023

gmagogsfm Aug 23, 2023

avikchaudhuri Aug 23, 2023

gmagogsfm Aug 23, 2023

gmagogsfm Aug 23, 2023

avikchaudhuri Aug 23, 2023

gmagogsfm Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

avikchaudhuri commented Aug 23, 2023

pytorchmergebot commented Aug 23, 2023

pytorchmergebot commented Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 24, 2023

facebook-github-bot commented Aug 24, 2023

avikchaudhuri commented Aug 24, 2023

pytorchmergebot commented Aug 24, 2023

pytorchmergebot commented Aug 24, 2023

facebook-github-bot commented Aug 24, 2023

avikchaudhuri commented Aug 24, 2023

pytorchmergebot commented Aug 24, 2023

remove redundant dynamic_dim #107815

remove redundant dynamic_dim #107815

Conversation

avikchaudhuri commented Aug 23, 2023 • edited by pytorch-bot bot Loading

pytorch-bot bot commented Aug 23, 2023 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107815

✅ You can merge normally! (1 Unrelated Failure)

facebook-github-bot commented Aug 23, 2023

angelayi Aug 23, 2023

Choose a reason for hiding this comment

gmagogsfm Aug 23, 2023

Choose a reason for hiding this comment

avikchaudhuri Aug 23, 2023

Choose a reason for hiding this comment

gmagogsfm Aug 23, 2023

Choose a reason for hiding this comment

gmagogsfm Aug 23, 2023

Choose a reason for hiding this comment

avikchaudhuri Aug 23, 2023

Choose a reason for hiding this comment

gmagogsfm Aug 23, 2023

Choose a reason for hiding this comment

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 23, 2023

avikchaudhuri commented Aug 23, 2023

pytorchmergebot commented Aug 23, 2023

Merge started

pytorchmergebot commented Aug 23, 2023

Merge failed

facebook-github-bot commented Aug 23, 2023

facebook-github-bot commented Aug 24, 2023

facebook-github-bot commented Aug 24, 2023

avikchaudhuri commented Aug 24, 2023

pytorchmergebot commented Aug 24, 2023

Merge started

pytorchmergebot commented Aug 24, 2023

Merge failed

facebook-github-bot commented Aug 24, 2023

avikchaudhuri commented Aug 24, 2023

pytorchmergebot commented Aug 24, 2023

Merge started

avikchaudhuri commented Aug 23, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 23, 2023 •

edited

Loading