Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo 3.11] changes to LOAD_GLOBAL and function calls #94098

Closed
wants to merge 21 commits into from
Closed

[dynamo 3.11] changes to LOAD_GLOBAL and function calls #94098

wants to merge 21 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Feb 4, 2023 •
edited
Loading

@williamwen42 williamwen42 mentioned this pull request Feb 4, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94098

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 3976d16:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Feb 4, 2023
Closed
Closed
Closed
Closed
@williamwen42 williamwen42 added this to the Python 3.11 milestone Feb 4, 2023
This was referenced Feb 4, 2023
Closed
Closed
Closed
Closed
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
d7d17d7 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
0a27955 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
f540b05 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42 williamwen42 mentioned this pull request Feb 7, 2023
Closed
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
cb824da 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
44f9660 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
0978a84 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
ce298d2 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
albanD
albanD reviewed Feb 7, 2023
View reviewed changes
torch/_dynamo/symbolic_convert.py Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
torch/_dynamo/codegen.py Show resolved Hide resolved
torch/_dynamo/codegen.py Outdated Show resolved Hide resolved
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
213b649 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
1f96876 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
jansel
jansel reviewed Feb 8, 2023
View reviewed changes
torch/_dynamo/bytecode_transformation.py Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
torch/_dynamo/symbolic_convert.py Outdated Show resolved Hide resolved
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
7ee52bd 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
albanD
albanD approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good! Thanks!

@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
7d8545f 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
35dbee0 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
b1fac76 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
ca7dfcd 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
1e26fd3 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
08bf999 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
bed02fb 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42 williamwen42 added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 15, 2023
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
a2e909d 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
1cc7ace 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@williamwen42
Update on "[dynamo 3.11] changes to LOAD_GLOBAL and function calls"
3976d16 
cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@huydhn huydhn mentioned this pull request Feb 24, 2023
Closed
@clee2000 clee2000 mentioned this pull request Feb 28, 2023
Closed
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@williamwen42 @cyyever
[dynamo 3.11] changes to LOAD_GLOBAL and function calls (#94098)
bf57672 
Pull Request resolved: pytorch/pytorch#94098
Approved by: https://github.com/albanD
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "[dynamo 3.11] changes to LOAD_GLOBAL and function calls (pyto…
fde7ab4 
…rch#94098)"

This reverts commit 055a9e4.
@facebook-github-bot facebook-github-bot deleted the gh/williamwen42/32/head branch June 8, 2023 19:20
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
@williamwen42 @jhavukainen
[dynamo 3.11] changes to LOAD_GLOBAL and function calls (pytorch#94098)
949214f 
Pull Request resolved: pytorch#94098
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel left review comments

@albanD albanD albanD approved these changes

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@mlazos mlazos Awaiting requested review from mlazos

@yanboliang yanboliang Awaiting requested review from yanboliang

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo
Projects
None yet
Milestone
Python 3.11
Development

Successfully merging this pull request may close these issues.
4 participants
@williamwen42 @jansel @albanD @pytorchmergebot