-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSDP][optim_state_dict] Make FSDP optim_state_dict aware of DDP prefix #96415
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96415
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a2ac3e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D43893609 |
This pull request was exported from Phabricator. Differential Revision: D43893609 |
…ix (pytorch#96415) Summary: Pull Request resolved: pytorch#96415 When wrapping FSDP within DDP, optimizer state_dict may be broken due to the prefix of DDP. This PR fixes the issue. Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D43893609 fbshipit-source-id: 32039229f56c052797b558e0266a5798332d792e
This pull request was exported from Phabricator. Differential Revision: D43893609 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D43893609 |
…ix (pytorch#96415) Summary: Pull Request resolved: pytorch#96415 When wrapping FSDP within DDP, optimizer state_dict may be broken due to the prefix of DDP. This PR fixes the issue. Test Plan: CI Reviewed By: zhaojuanmao Differential Revision: D43893609 fbshipit-source-id: efac71301a919bf57f63f3f2bfd4795d0ebb3e83
This pull request was exported from Phabricator. Differential Revision: D43893609 |
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ix (#96415) Summary: When wrapping FSDP within DDP, optimizer state_dict may be broken due to the prefix of DDP. This PR fixes the issue. Test Plan: CI Differential Revision: D43893609 Pull Request resolved: pytorch/pytorch#96415 Approved by: https://github.com/zhaojuanmao
…ix (#96415) Summary: When wrapping FSDP within DDP, optimizer state_dict may be broken due to the prefix of DDP. This PR fixes the issue. Test Plan: CI Differential Revision: D43893609 Pull Request resolved: pytorch/pytorch#96415 Approved by: https://github.com/zhaojuanmao
Summary: When wrapping FSDP within DDP, optimizer state_dict may be broken due to the prefix of DDP. This PR fixes the issue.
Test Plan: CI
Differential Revision: D43893609