-
Notifications
You must be signed in to change notification settings - Fork 22.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
masked_scatter
should accept only bool masks
#97999
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97999
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5c98e02: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I hope there won't be a SEV from byte removal, last time there was. |
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@ngimel good point, importing internally to see what is going on |
masked_scatter
shoudl accept only bool masksmasked_scatter
should accept only bool masks
Modify test_torch to check that assert is raised in this case torch.uint8 usage has been deprecated for a few releases, this diff finally removes it completely. Fixes #94634
e76fda5
to
5c98e02
Compare
@pytorchbot merge -ic |
Merge startedYour change will be merged while ignoring the following 1 checks: Meta Internal-Only Changes Check Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Modify test_torch to check that assert is raised in this case
torch.uint8 usage has been deprecated for a few releases, and errors has been raised for other dtypes on CUDA device, but not on CPU.
This PR finally restricts mask to just
torch.bool
See #96594 as an example doing it for
torch.masked_fill
Fixes #94634
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @mikaylagawarecki