Fix torch.nn.FractionalMaxPool2d output_size error #99507
Conversation
tfsingh
requested review from
albanD,
jbschlosser and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99507
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 FailuresAs of commit 513d3d2: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
tfsingh
changed the title
albanD
added
release notes: nn
|
Of course, just added it. Please let me know if there are any issues, I would be happy to iterate on them. |
There was a problem hiding this comment.
To fix the failing lint job running setup_lint and quicklint from your local pytorch directory and following the corresponding instructions should be sufficient, see here
test/test_nn.py
Outdated
| arg_3_0 = arg_3_0_tensor.clone() | ||
| arg_3 = [arg_3_0,] | ||
|
|
||
| with self.assertRaises(ValueError): |
There was a problem hiding this comment.
nit: could you use self.assertRaisesRegex instead to verify the correct error message is raised please
See here for an example of how to use assertRaisesRegex
There was a problem hiding this comment.
Of course, this + the lint issues should be fixed now!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 3, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "sympy import error unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #99148 , raising an error if output_ratio's size > 2.
Justification for changes:
If an output size is not specified but an output ratio is, we call fractional_max_pool2d_with_indices. We then generate the value of output_size based on the first two integers of the output_ratio (line ~480 of torch.nn.functional.py).
Thus, we should raise a value error in the case that the user passes an output_ratio (instead of an output_size) and the number of elements in output_ratio exceeds two. We must raise an error before calling torch._C._nn.franctional_max_pool2d as the value of output_size passed into torch._C._nn.fractional_max_pool2d is guaranteed to be of size 2 (as the existing code generates it from the first two indices of the passed in ratio).
I would be happy to iterate on this if there are any issues.
cc @albanD