freeze pip version #904

harshbafna · 2020-12-15T04:02:08Z

Description

Due to the latest released pip version, the builds are failing.

Open issues on pip GH repo

pypa/pip#9285
pypa/pip#9284
pypa/pip#9283

Log snippet from build failure

Requirement already satisfied: wheel in /usr/local/lib/python3.6/dist-packages (from -r requirements/common.txt (line 3)) (0.34.2)
Collecting wheel
  Downloading wheel-0.36.2-py2.py3-none-any.whl (35 kB)
  Downloading wheel-0.36.2.tar.gz (65 kB)
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/resolvers.py", line 171, in _merge_into_criterion
    crit = self.state.criteria[name]
KeyError: 'wheel'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/cli/base_command.py", line 224, in _main
    status = self.run(options, args)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/cli/req_command.py", line 180, in wrapper
    return func(self, options, args)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/commands/install.py", line 321, in run
    reqs, check_supported_wheels=not options.target_dir
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/resolver.py", line 122, in resolve
    requirements, max_rounds=try_to_avoid_resolution_too_deep,
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/resolvers.py", line 445, in resolve
    state = resolution.resolve(requirements, max_rounds=max_rounds)
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/resolvers.py", line 310, in resolve
    name, crit = self._merge_into_criterion(r, parent=None)
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/resolvers.py", line 173, in _merge_into_criterion
    crit = Criterion.from_requirement(self._p, requirement, parent)
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/resolvers.py", line 82, in from_requirement
    if not cands:
  File "/usr/local/lib/python3.6/dist-packages/pip/_vendor/resolvelib/structs.py", line 124, in __bool__
    return bool(self._sequence)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 96, in __bool__
    return any(self)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 81, in __iter__
    candidates = _insert_installed(self._installed, self._get_others())
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 44, in _insert_installed
    reverse=True,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/factory.py", line 241, in iter_index_candidates
    version=ican.version,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/factory.py", line 169, in _make_candidate_from_link
    name=name, version=version,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/candidates.py", line 302, in __init__
    version=version,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/candidates.py", line 144, in __init__
    self.dist = self._prepare()
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/candidates.py", line 222, in _prepare
    dist = self._prepare_distribution()
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/resolution/resolvelib/candidates.py", line 308, in _prepare_distribution
    self._ireq, parallel_builds=True,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/operations/prepare.py", line 480, in prepare_linked_requirement
    return self._prepare_linked_requirement(req, parallel_builds)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/operations/prepare.py", line 505, in _prepare_linked_requirement
    self.download_dir, hashes,
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/operations/prepare.py", line 263, in unpack_url
    unpack_file(file.path, location, file.content_type)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/utils/unpacking.py", line 270, in unpack_file
    untar_file(filename, location)
  File "/usr/local/lib/python3.6/dist-packages/pip/_internal/utils/unpacking.py", line 233, in untar_file
    with open(path, 'wb') as destfp:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 105-107: ordinal not in range(128)

Freezing the pip version to 20.3 major release.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Test A
Test B
UT/IT execution results
Logs

Checklist:

Have you added tests that prove your fix is effective or that this feature works?
New and existing unit tests pass locally with these changes?
Has code been commented, particularly in hard-to-understand areas?
Have you made corresponding changes to the documentation?

sagemaker-neo-ci-bot · 2020-12-15T04:31:46Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: b657c7e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T04:42:06Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: b657c7e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T04:58:20Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 5ddb2ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:02:24Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 5ddb2ff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

harshbafna · 2020-12-15T05:03:54Z

kubernetes/kfserving/kf_predictor_docker/Dockerfile_kf.dev

@@ -56,8 +56,6 @@ RUN if [ "$MACHINE_TYPE" = "gpu" ]; then export USE_CUDA=1; fi \
    && git checkout ${BRANCH_NAME} \
    && python ts_scripts/install_dependencies.py --environment=dev --cuda $CUDA_VERSION \
    && python ts_scripts/install_from_src.py \
-    && pip install captum \


removed these statements as these are installed as part of install_depenencies.py

the packages are already included in the common.txt and developer.txt requirements file.

sagemaker-neo-ci-bot · 2020-12-15T05:12:31Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: fdd4bb0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:16:22Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-cpu
Commit ID: 9eb0353
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:18:35Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: fdd4bb0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:24:23Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: 9eb0353
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:24:27Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-gpu
Commit ID: fdd4bb0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-neo-ci-bot · 2020-12-15T05:24:34Z

AWS CodeBuild CI Report

CodeBuild project: torch-serve-build-win
Commit ID: 9eb0353
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

harshbafna · 2020-12-15T07:19:33Z

This PR may not be required now as pip 20.3.2 has been yanked from PyPi and now the publicly available version is 20.3.1.

@dhanainme @maaquib

harshbafna · 2020-12-15T18:37:42Z

Closing this PR as pip has now released a newer version on pip : 20.3.3 and the issue is now resolved.

freeze wheel package version

b657c7e

harshbafna requested review from maaquib and dhanainme December 15, 2020 04:02

maaquib approved these changes Dec 15, 2020

View reviewed changes

maaquib assigned harshbafna Dec 15, 2020

maaquib added this to the v0.3.0 milestone Dec 15, 2020

dhanainme approved these changes Dec 15, 2020

View reviewed changes

freeze pip version

5ddb2ff

harshbafna added 2 commits December 15, 2020 10:21

pushed pip version to one more version

37c3305

freeze pip version in docker file dev

fdd4bb0

freeze pip version in kubernetes docker files

9eb0353

harshbafna changed the title ~~freeze wheel package version~~ freeze pip version Dec 15, 2020

harshbafna commented Dec 15, 2020

View reviewed changes

harshbafna mentioned this pull request Dec 15, 2020

torchserve sanity is failing on windows native #828

Closed

harshbafna closed this Dec 15, 2020

maaquib deleted the wheel_package_fix branch December 18, 2020 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

freeze pip version #904

freeze pip version #904

harshbafna commented Dec 15, 2020 •

edited

Loading

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

harshbafna Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

sagemaker-neo-ci-bot commented Dec 15, 2020

harshbafna commented Dec 15, 2020 •

edited

Loading

harshbafna commented Dec 15, 2020

freeze pip version #904

freeze pip version #904

Conversation

harshbafna commented Dec 15, 2020 • edited Loading

Description

Type of change

Feature/Issue validation/testing

Checklist:

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

harshbafna Dec 15, 2020

Choose a reason for hiding this comment

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

sagemaker-neo-ci-bot commented Dec 15, 2020

AWS CodeBuild CI Report

harshbafna commented Dec 15, 2020 • edited Loading

harshbafna commented Dec 15, 2020

harshbafna commented Dec 15, 2020 •

edited

Loading

harshbafna commented Dec 15, 2020 •

edited

Loading