fix 2D parallel crash caused by all-reduce on 2D world_mesh #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Mar 2, 2024
ghstack-source-id: 3f4046538ef80e36cfeb7d95cf92b986276b9b3c Pull Request resolved: #105
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
Mar 2, 2024
ghstack-source-id: 1c5bf790d7473f6a24124051fcfa1fd2585a56f9 Pull Request resolved: #105
wanchaol
approved these changes
Mar 2, 2024
tianyu-l
added a commit
that referenced
this pull request
Mar 2, 2024
ghstack-source-id: 1c5bf790d7473f6a24124051fcfa1fd2585a56f9 Pull Request resolved: #105
gnadathur
reviewed
Mar 2, 2024
| dp_degree = world_mesh.size(0) | ||
| dp_rank = world_mesh.get_local_rank(0) | ||
| dp_mesh = world_mesh["dp"] | ||
| dp_degree = dp_mesh.size() |
There was a problem hiding this comment.
There is also a config called data_parallel_degree. Should we use that ?
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
ghstack-source-id: 1c5bf790d7473f6a24124051fcfa1fd2585a56f9 Pull Request resolved: #105
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: 1c5bf790d7473f6a24124051fcfa1fd2585a56f9 Pull Request resolved: pytorch#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In 2D case (FSDP + SP), loss metric should be computed by doing all-reduce only on the DP submesh. Previously it was doing all-reduce on the world mesh; this PR fixes it.