Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to clean up parallelisms/__init__.py #150

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented Mar 15, 2024

wconstab added a commit that referenced this pull request Mar 15, 2024
ghstack-source-id: 7fdff827e86bb3167b74826aa745bed3695c8c61
Pull Request resolved: #150
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 15, 2024
@wconstab wconstab requested a review from wanchaol March 15, 2024 22:54
wconstab added a commit that referenced this pull request Mar 15, 2024
ghstack-source-id: d639bee40717fae4e9ec0f240fea1ba1d52dc392
Pull Request resolved: #150
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for the refactor!

@wconstab wconstab merged commit ca235f7 into gh/wconstab/1/base Mar 15, 2024
4 checks passed
@wconstab wconstab deleted the gh/wconstab/1/head branch March 15, 2024 23:41
@wconstab
Copy link
Contributor Author

oops i used the UI to merge and that doesn't work for ghstack..

tianyu-l pushed a commit that referenced this pull request Aug 16, 2024
tianyu-l pushed a commit that referenced this pull request Aug 16, 2024
ghstack-source-id: d639bee40717fae4e9ec0f240fea1ba1d52dc392
Pull Request resolved: #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants