Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followup changes to allow unsupported datasets #261

Merged
merged 2 commits into from
Apr 24, 2024
Merged

followup changes to allow unsupported datasets #261

merged 2 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. followup changes to allow unsupported datasets 

    [ghstack-poisoned]
    @tianyu-l
    tianyu-l committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2972fa7 View commit details
    Browse the repository at this point in the history

  2. Update on "followup changes to allow unsupported datasets" 

    1. Remove `build_dataloader_fn` as we only use HF data loading for now. And it helps allow unsupported dataset if user specify a `dataset_path`
2. If user uses an unsupported `dataset` without specifying `dataset_path`, we should still throw.

[ghstack-poisoned]
    @tianyu-l
    tianyu-l committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9ea236b View commit details
    Browse the repository at this point in the history