Separate TransformerEmbedding layer #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
wanchaol
approved these changes
Feb 2, 2024
torchtrain/models/llama/model.py
Outdated
| @@ -278,6 +278,40 @@ def forward(self, x): | |||
| return self.w2(F.silu(self.w1(x)) * self.w3(x)) | |||
|
|
|||
|
|
|||
| class TransformerEmbedding(nn.Module): | |||
There was a problem hiding this comment.
nit: maybe call it RotaryEmbedding as it does not only do plain embedding but also compute the freqs_cis?
Make it easier to chop Transformer into pieces for PP
wconstab
added a commit
that referenced
this pull request
Apr 10, 2024
wconstab
added a commit
that referenced
this pull request
Apr 10, 2024
wconstab
added a commit
that referenced
this pull request
Apr 10, 2024
wconstab
added a commit
that referenced
this pull request
Apr 10, 2024
wconstab
added a commit
that referenced
this pull request
Apr 10, 2024
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
Make it easier to chop Transformer into pieces for PP
lessw2020
pushed a commit
that referenced
this pull request
Apr 18, 2024
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
Avoid diverging the model structure (FQNs and checkpoint interoperability) with similar models. This reverts commit f30202c. ghstack-source-id: 9811f5fa99fdde387efe6018aa00afd28e7e923b Pull Request resolved: pytorch#214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to chop Transformer into pieces for PP