Cosmetic changes to train.py #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
kwen2501
added a commit
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: 0a7e0ea2808c9cb22a9a939c7797f4d4cd745ffa Pull Request resolved: #398
facebook-github-bot
added
the
CLA Signed
tianyu-l
approved these changes
Jun 13, 2024
train.py
Outdated
| @@ -142,15 +142,8 @@ def main(job_config: JobConfig): | |||
| torch.cuda.set_device(device) | |||
| init_distributed(job_config) | |||
|
|
|||
| # Build meshes | |||
There was a problem hiding this comment.
very nit: Build -> build to keep style consistent
- Move related code closer - Adjust comments [ghstack-poisoned]
kwen2501
added a commit
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: eb73cf29319ed40d115f68655ee5e9ad4f7c02fe Pull Request resolved: #398
- Move related code closer - Adjust comments [ghstack-poisoned]
kwen2501
added a commit
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: 75fe8612072535d205993416cfeca911099ea40d Pull Request resolved: #398
- Move related code closer - Adjust comments [ghstack-poisoned]
kwen2501
added a commit
that referenced
this pull request
Jun 13, 2024
ghstack-source-id: 7cb864d3bee58b3a65aff62c60f871712f83b242 Pull Request resolved: #398
- Move related code closer - Adjust comments [ghstack-poisoned]
kwen2501
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: ce4a5b0b6b785ce595487c9d565a8af030c9d07b Pull Request resolved: #398
kwen2501
added a commit
that referenced
this pull request
Jun 14, 2024
ghstack-source-id: ce4a5b0b6b785ce595487c9d565a8af030c9d07b Pull Request resolved: #398
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: ce4a5b0b6b785ce595487c9d565a8af030c9d07b Pull Request resolved: pytorch#398
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: ce4a5b0b6b785ce595487c9d565a8af030c9d07b Pull Request resolved: pytorch#398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):