updates here #417
Draft
updates here #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
H-Huang
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: ece40f9300738592a3c9b60353b76c82fedac617 Pull Request resolved: #417
facebook-github-bot
added
the
CLA Signed
wconstab
reviewed
Jun 24, 2024
| @@ -45,10 +45,25 @@ def build_pipeline_schedule(job_config, parallel_dims, stages, loss_fn): | |||
| if n_microbatches is None: | |||
| n_microbatches = job_config.experimental.pipeline_parallel_degree | |||
|
|
|||
| if job_config.experimental.pipeline_parallel_schedule == "zb": | |||
| stage_index_to_group_rank = { | |||
There was a problem hiding this comment.
nit: there should be a helper fn (in this file iirc) that produces this mapping for you. maybe its not in the right format though? i also wonder if we should land that helper to pytorch in some way.
tianyu-l
force-pushed
the
gh/H-Huang/1/head
branch
from
f0bc5fa
to
cbbfa37
Compare
tianyu-l
force-pushed
the
gh/H-Huang/1/base
branch
from
f261913
to
c0d34ea
Compare
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: ece40f9300738592a3c9b60353b76c82fedac617 Pull Request resolved: #417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Not for landing, just demonstrating changes