Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old torch dependency in requirements.txt #523

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Aug 15, 2024

Stack from ghstack (oldest at bottom):

This has been discussed earlier -- let's remove official torch dependency in requirements.txt because

  • it likely won't be useful, user will need a recent nightly anyway
  • depending on nightly in requirements.txt is not ideal, e.g. (1) we cannot specify device type so packages for every device will be downloaded, which could be unnecessarily big; (2) the latest nightly may not work anyway because of new changes in torch

tianyu-l added a commit that referenced this pull request Aug 15, 2024
ghstack-source-id: 7e1c7071f8126072ab0e25194b75f280bf4277ec
Pull Request resolved: #523
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 15, 2024
@tianyu-l tianyu-l marked this pull request as draft August 15, 2024 22:22
@tianyu-l tianyu-l marked this pull request as ready for review August 15, 2024 23:01
@tianyu-l tianyu-l requested review from wconstab and awgu August 15, 2024 23:01
@tianyu-l tianyu-l merged commit 7cec761 into gh/tianyu-l/21/base Aug 15, 2024
6 checks passed
tianyu-l added a commit that referenced this pull request Aug 15, 2024
ghstack-source-id: 7e1c7071f8126072ab0e25194b75f280bf4277ec
Pull Request resolved: #523
@tianyu-l tianyu-l deleted the gh/tianyu-l/21/head branch August 15, 2024 23:06
tianyu-l added a commit that referenced this pull request Aug 16, 2024
ghstack-source-id: 7e1c7071f8126072ab0e25194b75f280bf4277ec
Pull Request resolved: #523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants