Fix some zero-overhead checkpointing bugs #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fegin
added a commit
that referenced
this pull request
Oct 7, 2024
Summary: 1. The original code does not utitlize `share_memory=True`, this may cause incorrectness or slowdown. 2. The original code does not pass the correct cpu-offloaded state_dict, which can cause another slowdown or incorrect saving. ghstack-source-id: c04c634af9f377d860a021875bf65017b152a5c9 Pull Request resolved: #602
facebook-github-bot
added
the
CLA Signed
fegin
added a commit
that referenced
this pull request
Oct 7, 2024
Summary: 1. The original code does not utitlize `share_memory=True`, this may cause incorrectness or slowdown. 2. The original code does not pass the correct cpu-offloaded state_dict, which can cause another slowdown or incorrect saving. ghstack-source-id: c04c634af9f377d860a021875bf65017b152a5c9 Pull Request resolved: #602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
share_memory=True, this maycause incorrectness or slowdown.
which can cause another slowdown or incorrect saving.